Please remove all inline CSS from the PHP

WordPress Event Management, Calendars & Registration › Forums › General Question › Please remove all inline CSS from the PHP

This topic contains 4 replies, has 2 voices, and was last updated by  Matthew Tarzwell 9 years, 1 month ago.

Viewing 5 posts - 1 through 5 (of 5 total)
  • Author
    Posts
  • February 2, 2016 at 10:52 pm #21139

    Hi Stephen,

    I’m loving the plugin – our events page will be launching shortly.

    However, I keep getting annoyed at having to edit the core PHP files as every time the plugin updates, it removes my changes. I don’t like having to edit them at all, but unless I do so, many styles are unable to be overridden as you’ve got the style hard-coded into the script.

    In particular, I have to remove style=”margin:10px 0px;” from line 1505 of event-organiser/includes/event-organiser-event-functions.php – any chance of getting that style removed?

    Thanks very much.

    Oliver

    Matthew Tarzwell
    February 3, 2016 at 9:03 am #21144

    Thanks for reporting this Oliver, this will be fixed in 3.0.1

    Stephen Harris
    February 3, 2016 at 5:08 pm #21163

    Thanks Stephen.

    It’s your responsiveness to requests like these that make me certain I chose the right plugin. I appreciate it.

    Would you be able to list a mini-changelog of what you remove so that I can quickly tweak my CSS to accomodate (if it results in any adverse layout changes)?

    Thanks!

    Oliver

    Matthew Tarzwell
    February 4, 2016 at 9:42 pm #21185

    Hi Oliver,

    You can find all commits relating to this here: https://github.com/stephenharris/Event-Organiser/issues/334. There were only two frontend changes – the one you raised here and the ‘Loading…’ notice on the calendar.

    There are still inline-styles elsewhere in the plug-in, these were left as they either admin-side and so low-priority, or necessary (such as colouring events on the agenda widget, and to a lesser extent, the colour of category key for calendar).

    Any removed style attributes have been moved to an appropriate stylesheet.

    Stephen Harris
    February 4, 2016 at 9:47 pm #21186

    That’s great. Thanks Stephen.

    Matthew Tarzwell
  • Author
    Posts
Viewing 5 posts - 1 through 5 (of 5 total)
To enable me to focus on Pro customers, only users who have a valid license for the Pro add-on may post new topics or replies in this forum. If you have a valid license, please log-in or register an account using the e-mail address you purchased the license with. If you don't you can purchase one here. Or there's always the WordPress repository forum.